components/offline_pages/downloads/download_ui_adapter.cc - Issue 2512073002: [Offline Pages] Removes two-step expiration related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)

Patch Set: adding unit in histograms. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/downloads/download_ui_adapter.cc

diff --git a/components/offline_pages/downloads/download_ui_adapter.cc b/components/offline_pages/downloads/download_ui_adapter.cc

index bb398cb8f025d372546d0d669b1137e76a555acd..df7be3489f6bca4d4498821a4729b23d6b1efd25 100644

--- a/components/offline_pages/downloads/download_ui_adapter.cc

+++ b/components/offline_pages/downloads/download_ui_adapter.cc

@@ -123,9 +123,6 @@ void DownloadUIAdapter::DeleteItem(const std::string& guid) {

std::vector<int64_t> page_ids;

page_ids.push_back(it->second->offline_id);

- // TODO(dimich): This should be ExpirePages(...Now()..) when Expire is

- // firing Observer method. The resulting Observer notification will update

- // local cache.

model_->DeletePagesByOfflineId(

page_ids, base::Bind(&DownloadUIAdapter::OnDeletePagesDone,

weak_ptr_factory_.GetWeakPtr()));