chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc - Issue 2512073002: [Offline Pages] Removes two-step expiration related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)

Patch Set: adding unit in histograms. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils_unittest.cc ('k') | components/offline_pages/downloads/download_ui_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

index b587cfdced07d2075676e564c964e0abd50d0347..62732f967974875c7a869c2dc0f38468a8915f46 100644

--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

@@ -144,7 +144,6 @@ void OfflineInternalsUIMessageHandler::HandleStoredPagesCallback(

offline_page->SetDouble("creationTime", page.creation_time.ToJsTime());

offline_page->SetDouble("lastAccessTime", page.last_access_time.ToJsTime());

offline_page->SetInteger("accessCount", page.access_count);

- offline_page->SetString("isExpired", page.IsExpired() ? "Yes" : "No");

offline_page->SetString("originalUrl", page.original_url.spec());

}

ResolveJavascriptCallback(base::StringValue(callback_id), results);

@@ -196,7 +195,7 @@ void OfflineInternalsUIMessageHandler::HandleGetStoredPages(

CHECK(args->GetString(0, &callback_id));

if (offline_page_model_) {

- offline_page_model_->GetAllPagesWithExpired(

+ offline_page_model_->GetAllPages(

base::Bind(&OfflineInternalsUIMessageHandler::HandleStoredPagesCallback,

weak_ptr_factory_.GetWeakPtr(), callback_id));

} else {