Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1865)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
index 4eea23c5472a6cb57ba332e3e1479f6617f43eda..6229970ae3f94457d2ef58c6d9349edc3b27bc4d 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
@@ -41,7 +41,6 @@ const GURL kTestPage4Url("http://test.org/page4");
const int64_t kTestFileSize = 876543LL;
const char* kTestPage1ClientId = "1234";
const char* kTestPage2ClientId = "5678";
-const char* kTestPage4ClientId = "9876";
void BoolCallback(bool* actual_result, bool call_result) {
DCHECK(actual_result);
@@ -167,15 +166,6 @@ void OfflinePageUtilsTest::CreateOfflinePages() {
client_id.id = kTestPage2ClientId;
SavePage(kTestPage2Url, client_id, std::move(archiver));
- // Create page 4 - expired page.
- archiver = BuildArchiver(kTestPage4Url,
- base::FilePath(FILE_PATH_LITERAL("page4.mhtml")));
- client_id.id = kTestPage4ClientId;
- SavePage(kTestPage4Url, client_id, std::move(archiver));
- RunUntilIdle();
- model->ExpirePages(
- std::vector<int64_t>({offline_id()}), base::Time::Now(),
- base::Bind(&OfflinePageUtilsTest::OnExpirePageDone, AsWeakPtr()));
RunUntilIdle();
jianli 2016/11/18 00:15:48 This line can also be removed since SavePage waits
romax 2016/11/18 20:50:48 Done.
}

Powered by Google App Engine
This is Rietveld 408576698