chrome/browser/android/offline_pages/offline_page_bookmark_observer.h - Issue 2512073002: [Offline Pages] Removes two-step expiration related.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bookmark_observer.h

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc » ('j') | chrome/browser/android/offline_pages/offline_page_utils_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bookmark_observer.h

diff --git a/chrome/browser/android/offline_pages/offline_page_bookmark_observer.h b/chrome/browser/android/offline_pages/offline_page_bookmark_observer.h

index e5f859568da4538a7b8b5d7fcb96c60559c44f7d..68ed760e4b1446b723976cd4f8fa1b961be340a3 100644

--- a/chrome/browser/android/offline_pages/offline_page_bookmark_observer.h

+++ b/chrome/browser/android/offline_pages/offline_page_bookmark_observer.h

@@ -39,10 +39,10 @@ class OfflinePageBookmarkObserver

private:

// Does work for actual expiring.

fgorski 2016/11/18 00:13:04 fix comments to, please

romax 2016/11/18 20:50:48 Done.

- void DoExpireRemovedBookmarkPages(const MultipleOfflineIdResult& offline_ids);

+ void DoDeleteRemovedBookmarkPages(const MultipleOfflineIdResult& offline_ids);

// Callback for expiring removed bookmark pages.

- void OnExpireRemovedBookmarkPagesDone(bool result);

+ void OnDeleteRemovedBookmarkPagesDone(DeletePageResult result);

content::BrowserContext* context_;