Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2512023003: Don't call dispose() if the WebPluginContainer wasn't created (Closed)

Created:
4 years, 1 month ago by jrummell
Modified:
4 years, 1 month ago
Reviewers:
haraken, piman
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't call dispose() if the WebPluginContainer wasn't created If the plugin fails to load, then there is nothing to dispose. BUG=654556 Committed: https://crrev.com/a14a834fbf75248948031bb240c10c5494972432 Cr-Commit-Position: refs/heads/master@{#433096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebHelperPluginImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
jrummell
PTAL. Trivial change to check for null before calling dispose().
4 years, 1 month ago (2016-11-18 02:28:45 UTC) #2
haraken
LGTM
4 years, 1 month ago (2016-11-18 02:41:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512023003/1
4 years, 1 month ago (2016-11-18 04:13:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 04:21:14 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a14a834fbf75248948031bb240c10c5494972432 Cr-Commit-Position: refs/heads/master@{#433096}
4 years, 1 month ago (2016-11-18 04:24:00 UTC) #12
piman
4 years, 1 month ago (2016-11-18 18:12:38 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698