third_party/WebKit/Source/web/WebHelperPluginImpl.cpp - Issue 2512023003: Don't call dispose() if the WebPluginContainer wasn't created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

Issue 2512023003: Don't call dispose() if the WebPluginContainer wasn't created (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

index 1240b5b0e2b949f53395e4cd7e97a4372c7167ed..a5d5756f5d7b759cc692acfbbc36876aa69c50ca 100644

--- a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

+++ b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

@@ -79,7 +79,8 @@ bool WebHelperPluginImpl::initialize(const String& pluginType,

}

void WebHelperPluginImpl::reallyDestroy(TimerBase*) {

- m_pluginContainer->dispose();

+ if (m_pluginContainer)

+ m_pluginContainer->dispose();

delete this;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »