Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ios/web/history_state_util.cc

Issue 2511993004: [ObjC ARC] Converts ios/web:core to ARC.Automatically generated ARCMigrate commitNotable issues:… (Closed)
Patch Set: s/mm/cc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/crw_network_activity_indicator_manager.mm ('k') | ios/web/history_state_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/history_state_util.cc
diff --git a/ios/web/history_state_util.mm b/ios/web/history_state_util.cc
similarity index 90%
rename from ios/web/history_state_util.mm
rename to ios/web/history_state_util.cc
index bdb11bce32bd95b82d608ffe1d2d0666e19ffa39..232c4c02fd8fa8719637965fbacab63dcf6e5ff6 100644
--- a/ios/web/history_state_util.mm
+++ b/ios/web/history_state_util.cc
@@ -10,8 +10,7 @@
namespace web {
namespace history_state_util {
-bool IsHistoryStateChangeValid(const GURL& currentUrl,
- const GURL& toUrl) {
+bool IsHistoryStateChangeValid(const GURL& currentUrl, const GURL& toUrl) {
sdefresne 2016/11/21 15:45:00 Since it is now C++, can you rename the variables
stkhapugin 2016/11/22 14:20:58 Good idea! Done.
// These two checks are very important to the security of the page. We cannot
// allow the page to change the state to an invalid URL.
CHECK(currentUrl.is_valid());
« no previous file with comments | « ios/web/crw_network_activity_indicator_manager.mm ('k') | ios/web/history_state_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698