[ObjC ARC] Converts ios/web:core to ARC.Automatically generated ARCMigrate commitNotable issues:…

ios/web/history_state_util.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/history_state_util.h"
 
 #include "base/logging.h"
 #include "url/gurl.h"
 
 namespace web {
 namespace history_state_util {
 
-bool IsHistoryStateChangeValid(const GURL& currentUrl,
-                               const GURL& toUrl) {
+bool IsHistoryStateChangeValid(const GURL& currentUrl, const GURL& toUrl) {

[sdefresne, 2016/11/21 15:45:00]

Since it is now C++, can you rename the variables to follow C++ style guide?

currentURL -> current_url
toUrl -> to_url
baseUrl -> base_url

[stkhapugin, 2016/11/22 14:20:58]

Good idea! Done. 

   // These two checks are very important to the security of the page. We cannot
   // allow the page to change the state to an invalid URL.
   CHECK(currentUrl.is_valid());
   CHECK(toUrl.is_valid());
 
   return toUrl.GetOrigin() == currentUrl.GetOrigin();
 }
 
 GURL GetHistoryStateChangeUrl(const GURL& currentUrl,
                               const GURL& baseUrl,
                               const std::string& destination) {
   if (!baseUrl.is_valid())
     return GURL();
   GURL toUrl = baseUrl.Resolve(destination);
 
   if (!toUrl.is_valid() || !IsHistoryStateChangeValid(currentUrl, toUrl))
     return GURL();
 
   return toUrl;
 }
 
 }  // namespace history_state_util
 }  // namespace web