[ObjC ARC] Converts ios/web:core to ARC.Automatically generated ARCMigrate commitNotable issues:…

[ObjC ARC] Converts ios/web:core to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/2c99fc2edeac87418e8b24939acc78a0ed628270
Cr-Commit-Position: refs/heads/master@{#433864}

[stkhapugin, 2016-11-18 17:01:57]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 17:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 18:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 18:42:36]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2016-11-21 12:20:15]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2016-11-21 12:20:16]

PTAL. Passes downstream tests.🐱

[sdefresne, 2016-11-21 12:34:30]

https://codereview.chromium.org/2511993004/diff/1/ios/web/history_state_util.mm
File ios/web/history_state_util.mm (right):

https://codereview.chromium.org/2511993004/diff/1/ios/web/history_state_util....
ios/web/history_state_util.mm:5: #import "ios/web/history_state_util.h"
This file has no Objective-C AFAICT. I think it would be better to just rename
it ios/web/history_state_util.cc

[stkhapugin, 2016-11-21 15:38:31]

Thanks, PTAL

https://codereview.chromium.org/2511993004/diff/1/ios/web/history_state_util.mm
File ios/web/history_state_util.mm (right):

https://codereview.chromium.org/2511993004/diff/1/ios/web/history_state_util....
ios/web/history_state_util.mm:5: #import "ios/web/history_state_util.h"
On 2016/11/21 12:34:30, sdefresne wrote:
> This file has no Objective-C AFAICT. I think it would be better to just rename
> it ios/web/history_state_util.cc

Done.

[sdefresne, 2016-11-21 15:45:00]

lgtm

https://codereview.chromium.org/2511993004/diff/20001/ios/web/history_state_u...
File ios/web/history_state_util.cc (right):

https://codereview.chromium.org/2511993004/diff/20001/ios/web/history_state_u...
ios/web/history_state_util.cc:13: bool IsHistoryStateChangeValid(const GURL&
currentUrl, const GURL& toUrl) {
Since it is now C++, can you rename the variables to follow C++ style guide?

currentURL -> current_url
toUrl -> to_url
baseUrl -> base_url

[stkhapugin, 2016-11-22 14:20:58]

https://codereview.chromium.org/2511993004/diff/20001/ios/web/history_state_u...
File ios/web/history_state_util.cc (right):

https://codereview.chromium.org/2511993004/diff/20001/ios/web/history_state_u...
ios/web/history_state_util.cc:13: bool IsHistoryStateChangeValid(const GURL&
currentUrl, const GURL& toUrl) {
On 2016/11/21 15:45:00, sdefresne wrote:
> Since it is now C++, can you rename the variables to follow C++ style guide?
> 
> currentURL -> current_url
> toUrl -> to_url
> baseUrl -> base_url

Good idea! Done.

[stkhapugin, 2016-11-22 14:21:02]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2016-11-22 14:21:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2511993004/#ps40001
(title: "rename variables")

[commit-bot: I haz the power, 2016-11-22 14:21:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:27:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479824462853560,
"parent_rev": "0c2e3224fcfb1ae851cdd11e3dc5cbc7a6448f97", "commit_rev":
"ee745b1636a053528f28b76d2f75bb95cd708678"}

[commit-bot: I haz the power, 2016-11-22 15:28:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 15:29:56]

Description was changed from

==========
[ObjC ARC] Converts ios/web:core to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/web:core to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/2c99fc2edeac87418e8b24939acc78a0ed628270
Cr-Commit-Position: refs/heads/master@{#433864}
==========

[commit-bot: I haz the power, 2016-11-22 15:29:57]

Patchset 3 (id:??) landed as
https://crrev.com/2c99fc2edeac87418e8b24939acc78a0ed628270
Cr-Commit-Position: refs/heads/master@{#433864}