Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2511993003: [ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC.Automatically generated ARC… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
Olivier
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b7ecc87fb1c5b2ce43ba29418298f34653585908 Cr-Commit-Position: refs/heads/master@{#434373}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/reading_list/BUILD.gn View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 19 (10 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 13:05:44 UTC) #6
Olivier
https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_list/BUILD.gn File ios/chrome/browser/reading_list/BUILD.gn (right): https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_list/BUILD.gn#newcode56 ios/chrome/browser/reading_list/BUILD.gn:56: configs += [ "//build/config/compiler:enable_arc" ] I don't understand the ...
4 years, 1 month ago (2016-11-21 16:17:42 UTC) #7
stkhapugin
https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_list/BUILD.gn File ios/chrome/browser/reading_list/BUILD.gn (right): https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_list/BUILD.gn#newcode56 ios/chrome/browser/reading_list/BUILD.gn:56: configs += [ "//build/config/compiler:enable_arc" ] On 2016/11/21 16:17:42, Olivier ...
4 years, 1 month ago (2016-11-21 17:03:33 UTC) #8
Olivier
LGTM (but I think that this could have been done at the same time as ...
4 years, 1 month ago (2016-11-21 17:09:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511993003/1
4 years ago (2016-11-24 12:53:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/304132)
4 years ago (2016-11-24 15:21:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511993003/1
4 years ago (2016-11-24 17:51:34 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 18:57:26 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-24 18:59:47 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7ecc87fb1c5b2ce43ba29418298f34653585908
Cr-Commit-Position: refs/heads/master@{#434373}

Powered by Google App Engine
This is Rietveld 408576698