|
|
Created:
4 years, 1 month ago by stkhapugin Modified:
4 years ago Reviewers:
Olivier CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Committed: https://crrev.com/b7ecc87fb1c5b2ce43ba29418298f34653585908
Cr-Commit-Position: refs/heads/master@{#434373}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (10 generated)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stkhapugin@chromium.org changed reviewers: + olivierrobin@chromium.org
PTAL. Passes downstream tests.
https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_... File ios/chrome/browser/reading_list/BUILD.gn (right): https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_... ios/chrome/browser/reading_list/BUILD.gn:56: configs += [ "//build/config/compiler:enable_arc" ] I don't understand the point on a C++ target.
https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_... File ios/chrome/browser/reading_list/BUILD.gn (right): https://codereview.chromium.org/2511993003/diff/1/ios/chrome/browser/reading_... ios/chrome/browser/reading_list/BUILD.gn:56: configs += [ "//build/config/compiler:enable_arc" ] On 2016/11/21 16:17:42, Olivier Robin wrote: > I don't understand the point on a C++ target. Should we ever add an objective-c file here, this will force people to write ARC.
LGTM (but I think that this could have been done at the same time as converting the reading_list target).
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by olivierrobin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1480009872973980, "parent_rev": "346c5d8497e716dac12e52dd3474a141603d7890", "commit_rev": "b746b7b54a1e321c53a421a385f8e8be80842ff6"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b7ecc87fb1c5b2ce43ba29418298f34653585908 Cr-Commit-Position: refs/heads/master@{#434373} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b7ecc87fb1c5b2ce43ba29418298f34653585908 Cr-Commit-Position: refs/heads/master@{#434373} |