Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: ios/chrome/browser/reading_list/BUILD.gn

Issue 2511993003: [ObjC ARC] Converts ios/chrome/browser/reading_list:unit_tests to ARC.Automatically generated ARC… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("reading_list") { 5 source_set("reading_list") {
6 sources = [ 6 sources = [
7 "offline_url_utils.cc", 7 "offline_url_utils.cc",
8 "offline_url_utils.h", 8 "offline_url_utils.h",
9 "reading_list_download_service.cc", 9 "reading_list_download_service.cc",
10 "reading_list_download_service.h", 10 "reading_list_download_service.h",
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 "//ios/web", 46 "//ios/web",
47 "//net", 47 "//net",
48 "//url", 48 "//url",
49 ] 49 ]
50 public_deps = [ 50 public_deps = [
51 "//ios/chrome/browser/dom_distiller", 51 "//ios/chrome/browser/dom_distiller",
52 ] 52 ]
53 } 53 }
54 54
55 source_set("unit_tests") { 55 source_set("unit_tests") {
56 configs += [ "//build/config/compiler:enable_arc" ]
Olivier 2016/11/21 16:17:42 I don't understand the point on a C++ target.
stkhapugin 2016/11/21 17:03:32 Should we ever add an objective-c file here, this
56 testonly = true 57 testonly = true
57 sources = [ 58 sources = [
58 "offline_url_utils_unittest.cc", 59 "offline_url_utils_unittest.cc",
59 "reading_list_entry_unittest.cc", 60 "reading_list_entry_unittest.cc",
60 "reading_list_model_unittest.cc", 61 "reading_list_model_unittest.cc",
61 "reading_list_store_unittest.cc", 62 "reading_list_store_unittest.cc",
62 "url_downloader_unittest.cc", 63 "url_downloader_unittest.cc",
63 ] 64 ]
64 deps = [ 65 deps = [
65 ":reading_list", 66 ":reading_list",
66 "//base", 67 "//base",
67 "//base/test:test_support", 68 "//base/test:test_support",
68 "//components/sync:test_support_model", 69 "//components/sync:test_support_model",
69 "//components/sync/protocol", 70 "//components/sync/protocol",
70 "//ios/chrome/browser", 71 "//ios/chrome/browser",
71 "//ios/chrome/browser/dom_distiller", 72 "//ios/chrome/browser/dom_distiller",
72 "//ios/chrome/browser/reading_list/proto", 73 "//ios/chrome/browser/reading_list/proto",
73 "//ios/web:test_support", 74 "//ios/web:test_support",
74 "//testing/gtest", 75 "//testing/gtest",
75 "//url", 76 "//url",
76 ] 77 ]
77 } 78 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698