components: Cleanup class/struct fwd declarations

components: Cleanup class/struct fwd declarations

Remove useless class and struct forward declarations, and add
missing ones in components header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/0274b6dfab86377a44f06dfe41895c9763f9f449
Cr-Commit-Position: refs/heads/master@{#434299}

[jbriance, 2016-11-18 10:47:16]

jbriance@cisco.com changed reviewers:
+ blundell@chromium.org, jochen@chromium.org, sdefresne@chromium.org

[vabr (Chromium), 2016-11-18 12:32:27]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2016-11-18 12:32:28]

components/autofill and components/password_manager LGTM as long as all bots
compile OK.

Cheers,
Vaclav

[jbriance, 2016-11-18 12:35:56]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 12:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 13:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 13:03:53]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[jbriance, 2016-11-18 14:21:47]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 14:22:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 14:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 14:52:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[jbriance, 2016-11-18 15:03:56]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 15:04:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 17:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:42:20]

Dry run: This issue passed the CQ dry run.

[vakh (use Gerrit instead), 2016-11-18 23:46:24]

vakh@chromium.org changed reviewers:
+ vakh@chromium.org

[vakh (use Gerrit instead), 2016-11-18 23:46:25]

lgtm for components/safe_browsing_db/*

[jochen (gone - plz use gerrit), 2016-11-21 11:05:00]

I added some questions to the tracking bug, could you please answer them?

[jbriance, 2016-11-21 12:42:03]

On 2016/11/21 11:05:00, jochen wrote:
> I added some questions to the tracking bug, could you please answer them?

Done :)

[jochen (gone - plz use gerrit), 2016-11-23 15:07:50]

lgtm, but please make sure to add some form of presubmit check

[jbriance, 2016-11-23 15:24:12]

Ok, I send this one in the CQ then I'll work on a presubmit check

[jbriance, 2016-11-23 15:24:23]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-23 15:24:24]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2511973004/#ps40001
(title: "Other android and mac fixes")

[commit-bot: I haz the power, 2016-11-23 15:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-11-23 15:26:42]

lgtm

+1 to the suggestion of adding a PRESUBMIT otherwise I'm afraid this will
eventually regress,

[commit-bot: I haz the power, 2016-11-23 15:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 15:30:32]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbriance, 2016-11-23 17:00:29]

Description was changed from

==========
components: Cleanup class/struct fwd declarations

Remove useless class and struct forward declarations, and add
missing ones in components header files.

BUG=662195
==========

to

==========
components: Cleanup class/struct fwd declarations

Remove useless class and struct forward declarations, and add
missing ones in components header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[jbriance, 2016-11-23 17:01:02]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:01:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 22:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 22:09:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbriance, 2016-11-23 22:27:07]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-23 22:27:08]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
vakh@chromium.org, jochen@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2511973004/#ps60001
(title: "Rebase on top of current master branch")

[commit-bot: I haz the power, 2016-11-23 22:28:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 00:53:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479940027166330,
"parent_rev": "0be728640d9140ec78503f7fbfa11e7174bb71d5", "commit_rev":
"6c758f8ce8044bad29a16c5eb90225b2fbd2630f"}

[commit-bot: I haz the power, 2016-11-24 00:53:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-24 00:55:09]

Description was changed from

==========
components: Cleanup class/struct fwd declarations

Remove useless class and struct forward declarations, and add
missing ones in components header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
components: Cleanup class/struct fwd declarations

Remove useless class and struct forward declarations, and add
missing ones in components header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Committed: https://crrev.com/0274b6dfab86377a44f06dfe41895c9763f9f449
Cr-Commit-Position: refs/heads/master@{#434299}
==========

[commit-bot: I haz the power, 2016-11-24 00:55:12]

Patchset 4 (id:??) landed as
https://crrev.com/0274b6dfab86377a44f06dfe41895c9763f9f449
Cr-Commit-Position: refs/heads/master@{#434299}