Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2511883007: Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARC... (Closed)

Created:
4 years, 1 month ago by michaeldo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=624363 Committed: https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8 Cr-Commit-Position: refs/heads/master@{#433383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M ios/chrome/browser/prefs/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/prefs/pref_observer_bridge.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
michaeldo
Created Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm…
4 years, 1 month ago (2016-11-19 00:13:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511883007/1
4 years, 1 month ago (2016-11-19 01:08:52 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-19 01:08:54 UTC) #12
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-19 02:20:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511883007/1
4 years, 1 month ago (2016-11-19 02:21:08 UTC) #18
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 1 month ago (2016-11-19 02:21:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511883007/1
4 years, 1 month ago (2016-11-19 02:26:45 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 02:27:33 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 02:30:56 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8
Cr-Commit-Position: refs/heads/master@{#433383}

Powered by Google App Engine
This is Rietveld 408576698