|
|
DescriptionRevert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ )
Reason for revert:
Breaks roll. Details sent via email.
Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1
> Cr-Commit-Position: refs/heads/master@{#433243}
TBR=noyau@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTRY=true
BUG=624363
Committed: https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8
Cr-Commit-Position: refs/heads/master@{#433383}
Patch Set 1 #
Messages
Total messages: 27 (18 generated)
The CQ bit was checked by michaeldo@chromium.org
Created Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm…
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by michaeldo@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by michaeldo@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Description was changed from ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 ========== to ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true TBR=noyau BUG=624363 ==========
The CQ bit was checked by michaeldo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true TBR=noyau BUG=624363 ========== to ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=624363 ==========
michaeldo@chromium.org changed required reviewers: + noyau@chromium.org
eugenebut@chromium.org changed reviewers: + eugenebut@chromium.org
The CQ bit was checked by eugenebut@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
eugenebut@chromium.org changed required reviewers: - noyau@chromium.org
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=624363 ========== to ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=624363 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=624363 ========== to ========== Revert of [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (patchset #1 id:1 of https://codereview.chromium.org/2506153004/ ) Reason for revert: Breaks roll. Details sent via email. Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 > Cr-Commit-Position: refs/heads/master@{#433243} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=624363 Committed: https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8 Cr-Commit-Position: refs/heads/master@{#433383} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d818f8b62ef17511721b558228cff6a6e460d7f8 Cr-Commit-Position: refs/heads/master@{#433383} |