Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2506153004: [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC.Automatically generated ARCMigrate comm… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 Cr-Commit-Position: refs/heads/master@{#433243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/prefs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/prefs/pref_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-18 17:05:02 UTC) #4
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-18 17:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506153004/1
4 years, 1 month ago (2016-11-18 18:19:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:27:54 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dc7a6cd5cc6d8b07647c2876f1534a46fccb6aa1 Cr-Commit-Position: refs/heads/master@{#433243}
4 years, 1 month ago (2016-11-18 18:32:04 UTC) #12
michaeldo
4 years, 1 month ago (2016-11-19 00:13:57 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2511883007/ by michaeldo@chromium.org.

The reason for reverting is: Breaks roll. Details sent via email..

Powered by Google App Engine
This is Rietveld 408576698