Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: ios/chrome/browser/sync/ios_chrome_sync_client.mm

Issue 2511723002: Enable RL sync by default on iOS (Closed)
Patch Set: add guard Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/sync/ios_chrome_sync_client.mm
diff --git a/ios/chrome/browser/sync/ios_chrome_sync_client.mm b/ios/chrome/browser/sync/ios_chrome_sync_client.mm
index ed427b610645eab597492205a563069490c2844e..74ce61a81bae8d99b8b4868afefc9e134626496e 100644
--- a/ios/chrome/browser/sync/ios_chrome_sync_client.mm
+++ b/ios/chrome/browser/sync/ios_chrome_sync_client.mm
@@ -338,10 +338,12 @@ IOSChromeSyncClient::GetSyncBridgeForModelType(syncer::ModelType type) {
->GetDeviceInfoSyncBridge()
->AsWeakPtr();
case syncer::READING_LIST: {
- ReadingListModel* reading_list_model =
- ReadingListModelFactory::GetForBrowserState(browser_state_);
- if (reading_list_model)
- return reading_list_model->GetModelTypeSyncBridge()->AsWeakPtr();
+ if (ReadingListModelFactory::IsReadingListEnabled()) {
pavely 2016/11/20 02:31:58 It is an issue when GetSyncBridgeForModelType retu
Olivier 2016/11/20 10:32:33 Problem is that ReadingListService is in ios/chrom
+ ReadingListModel* reading_list_model =
+ ReadingListModelFactory::GetForBrowserState(browser_state_);
+ if (reading_list_model)
+ return reading_list_model->GetModelTypeSyncBridge()->AsWeakPtr();
+ }
return base::WeakPtr<syncer::ModelTypeSyncBridge>();
}
default:

Powered by Google App Engine
This is Rietveld 408576698