Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/browser_sync/profile_sync_components_factory_impl.cc

Issue 2511723002: Enable RL sync by default on iOS (Closed)
Patch Set: add guard Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_components_factory_impl.cc
diff --git a/components/browser_sync/profile_sync_components_factory_impl.cc b/components/browser_sync/profile_sync_components_factory_impl.cc
index c4332e02bdc969cd0fa5b05a11bd7e5b61822f33..62bebd611543e536d0a513f5f7660733a1515adb 100644
--- a/components/browser_sync/profile_sync_components_factory_impl.cc
+++ b/components/browser_sync/profile_sync_components_factory_impl.cc
@@ -274,14 +274,17 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
base::MakeUnique<UIDataTypeController>(syncer::ARTICLES, error_callback,
sync_client_));
}
- // Reading list sync is disabled by default. Register only if explicitly
- // enabled.
- if (enabled_types.Has(syncer::READING_LIST)) {
+
+#if defined(OS_IOS)
pavely 2016/11/20 02:31:58 Yes, this is a correct way to only enable type on
Olivier 2016/11/20 10:32:33 Acknowledged.
+ // Reading list sync is enabled by default only on iOS. Register unless
+ // explicitly disabled.
+ if (!disabled_types.Has(syncer::READING_LIST)) {
sync_service->RegisterDataTypeController(
base::MakeUnique<ModelTypeController>(
syncer::READING_LIST, error_callback, sync_client_,
base::ThreadTaskRunnerHandle::Get()));
}
+#endif
}
DataTypeManager* ProfileSyncComponentsFactoryImpl::CreateDataTypeManager(

Powered by Google App Engine
This is Rietveld 408576698