Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink. (Closed)
Patch Set: Making sure updateIce doesn't change behavior in this CL. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.h
diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h
index 276e4a41f6b8443f22a862142c0e0aa2f851243a..a8832ce0190a9bcf1669238856495f57631abde1 100644
--- a/content/renderer/media/rtc_peer_connection_handler.h
+++ b/content/renderer/media/rtc_peer_connection_handler.h
@@ -132,8 +132,8 @@ class CONTENT_EXPORT RTCPeerConnectionHandler
blink::WebRTCSessionDescription localDescription() override;
blink::WebRTCSessionDescription remoteDescription() override;
- bool updateICE(
- const blink::WebRTCConfiguration& server_configuration) override;
+ bool setConfiguration(
+ const blink::WebRTCConfiguration& configuration) override;
void logSelectedRtcpMuxPolicy(
blink::RtcpMuxPolicy selectedRtcpMuxPolicy) override;
bool addICECandidate(const blink::WebRTCICECandidate& candidate) override;
@@ -271,6 +271,11 @@ class CONTENT_EXPORT RTCPeerConnectionHandler
// |native_peer_connection_| is the libjingle native PeerConnection object.
scoped_refptr<webrtc::PeerConnectionInterface> native_peer_connection_;
+ // The last applied configuration. Used so that the constraints
+ // used when constructing the PeerConnection carry over when
+ // SetConfiguration is called.
+ webrtc::PeerConnectionInterface::RTCConfiguration configuration_;
+
// Record info about the first SessionDescription from the local and
// remote side to record UMA stats once both are set. We only check
// for the first offer or answer. "pranswer"s and "unknown"s (from

Powered by Google App Engine
This is Rietveld 408576698