content/renderer/media/peer_connection_tracker.h - Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/peer_connection_tracker.h

Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink. (Closed)

Patch Set: Making sure updateIce doesn't change behavior in this CL. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/peer_connection_tracker.h

diff --git a/content/renderer/media/peer_connection_tracker.h b/content/renderer/media/peer_connection_tracker.h

index 06ad20700df0c9cdb99040a0343875a2e52fdb0d..5f1673f7342f681d56e366bc60a8ce2dc818ba7b 100644

--- a/content/renderer/media/peer_connection_tracker.h

+++ b/content/renderer/media/peer_connection_tracker.h

@@ -102,8 +102,8 @@ class CONTENT_EXPORT PeerConnectionTracker

RTCPeerConnectionHandler* pc_handler,

const std::string& sdp, const std::string& type, Source source);

- // Sends an update when Ice candidates are updated.

- virtual void TrackUpdateIce(

+ // Sends an update when setConfiguration is called.

+ virtual void TrackSetConfiguration(

RTCPeerConnectionHandler* pc_handler,

const webrtc::PeerConnectionInterface::RTCConfiguration& config);