content/renderer/media/mock_peer_connection_impl.h - Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/mock_peer_connection_impl.h

Issue 2511633002: Rename "updateICE" to "setConfiguration", everywhere except in Blink. (Closed)

Patch Set: Making sure updateIce doesn't change behavior in this CL. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/mock_peer_connection_impl.h

diff --git a/content/renderer/media/mock_peer_connection_impl.h b/content/renderer/media/mock_peer_connection_impl.h

index 1227f3204fabcaf9794c43f9964c86220fd9f0e8..83765f21b4edf162ff863aea431e9f82c95e0cb5 100644

--- a/content/renderer/media/mock_peer_connection_impl.h

+++ b/content/renderer/media/mock_peer_connection_impl.h

@@ -92,7 +92,7 @@ class MockPeerConnectionImpl : public webrtc::PeerConnectionInterface {

void SetRemoteDescriptionWorker(

webrtc::SetSessionDescriptionObserver* observer,

webrtc::SessionDescriptionInterface* desc);

- bool UpdateIce(const IceServers& configuration) override;

+ bool SetConfiguration(const RTCConfiguration& configuration) override;

bool AddIceCandidate(const webrtc::IceCandidateInterface* candidate) override;

void RegisterUMAObserver(webrtc::UMAObserver* observer) override;