[ic] Support data handlers in LoadGlobalIC.

[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of load non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854
Committed: https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7
Cr-Commit-Position: refs/heads/master@{#41073}

[Igor Sheludko, 2016-11-17 00:25:16]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-11-17 00:25:51]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-11-17 00:31:11]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-11-17 00:35:15]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-11-17 00:35:54]

Description was changed from

==========
[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of a non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854
==========

to

==========
[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of load non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854
==========

[Igor Sheludko, 2016-11-17 00:38:53]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 00:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-17 00:39:06]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-11-17 00:39:07]

PTAL

[commit-bot: I haz the power, 2016-11-17 01:01:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:01:51]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16312)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Igor Sheludko, 2016-11-17 08:51:35]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 08:51:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 09:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 09:19:09]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Jakob Kummerow, 2016-11-17 10:44:21]

LGTM with nit. What's with the try job crashes?

https://codereview.chromium.org/2511603002/diff/100001/src/ic/accessor-assemb...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2511603002/diff/100001/src/ic/accessor-assemb...
src/ic/accessor-assembler.cc:1205: void
AccessorAssemblerImpl::HandleLoadGlobalICHandlerCase(
nit: please move this up to where the other Handle...Case() helpers are. Line
453, between HandleLoad...Case and HandleStore...Case, seems like a good place.

[Igor Sheludko, 2016-11-17 11:32:09]

https://codereview.chromium.org/2511603002/diff/100001/src/ic/accessor-assemb...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2511603002/diff/100001/src/ic/accessor-assemb...
src/ic/accessor-assembler.cc:1205: void
AccessorAssemblerImpl::HandleLoadGlobalICHandlerCase(
On 2016/11/17 10:44:21, Jakob Kummerow wrote:
> nit: please move this up to where the other Handle...Case() helpers are. Line
> 453, between HandleLoad...Case and HandleStore...Case, seems like a good
place.

Done.

https://codereview.chromium.org/2511603002/diff/120001/src/ic/accessor-assemb...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2511603002/diff/120001/src/ic/accessor-assemb...
src/ic/accessor-assembler.cc:344: HasInstanceType(p->receiver,
JS_GLOBAL_OBJECT_TYPE)));
The catcher.

https://codereview.chromium.org/2511603002/diff/120001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2511603002/diff/120001/src/ic/ic.cc#newcode988
src/ic/ic.cc:988: receiver_map->is_dictionary_map() &&
!receiver_map->IsJSGlobalObjectMap();
The fix.

[Igor Sheludko, 2016-11-17 11:32:16]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 11:32:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 12:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 12:00:12]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-11-17 12:16:16]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-11-17 12:16:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2511603002/#ps120001
(title: "Addressing comments and fix")

[commit-bot: I haz the power, 2016-11-17 12:16:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 12:18:27]

Description was changed from

==========
[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of load non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854
==========

to

==========
[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of load non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854
==========

[commit-bot: I haz the power, 2016-11-17 12:18:28]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-11-17 22:38:08]

Description was changed from

==========
[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of load non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854
==========

to

==========
[ic] Support data handlers in LoadGlobalIC.

Also fixed handling of load non-existent handlers outside typeof.

BUG=v8:5561, chromium:662854

Committed: https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7
Cr-Commit-Position: refs/heads/master@{#41073}
==========

[commit-bot: I haz the power, 2016-11-17 22:38:09]

Patchset 3 (id:??) landed as
https://crrev.com/937b8cb6847041dd2801eaa06fdaf0e5305abbc7
Cr-Commit-Position: refs/heads/master@{#41073}