src/type-feedback-vector.cc - Issue 2511603002: [ic] Support data handlers in LoadGlobalIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-feedback-vector.cc

Issue 2511603002: [ic] Support data handlers in LoadGlobalIC. (Closed)

Patch Set: Addressing comments and fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-feedback-vector.cc

diff --git a/src/type-feedback-vector.cc b/src/type-feedback-vector.cc

index 2ba9690b9fd3de2c47edfcfc0bb6214bc0fe1ce5..9130c79f2a93340326e0b2b81efe57cb599a85b1 100644

--- a/src/type-feedback-vector.cc

+++ b/src/type-feedback-vector.cc

@@ -713,7 +713,7 @@ void LoadGlobalICNexus::ConfigurePropertyCellMode(Handle<PropertyCell> cell) {

SKIP_WRITE_BARRIER);

}

-void LoadGlobalICNexus::ConfigureHandlerMode(Handle<Code> handler) {

+void LoadGlobalICNexus::ConfigureHandlerMode(Handle<Object> handler) {

SetFeedback(GetIsolate()->heap()->empty_weak_cell());

SetFeedbackExtra(*handler);

}