content/browser/compositor/software_browser_compositor_output_surface_unittest.cc - Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource. (Closed)

Patch Set: Another attempt to fix the crash Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_process_transport_factory.cc ('K') | « content/browser/compositor/software_browser_compositor_output_surface.cc ('k') | content/browser/renderer_host/delegated_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

diff --git a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

index a91c8326a45bf704bcd8a837702513aef70afdc8..15fdf141dc5812d5f55dfec5a012259bea392391 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

+++ b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

@@ -97,6 +97,7 @@ void SoftwareBrowserCompositorOutputSurfaceTest::SetUp() {

compositor_.reset(

new ui::Compositor(context_factory, message_loop_.task_runner().get()));

compositor_->SetAcceleratedWidget(gfx::kNullAcceleratedWidget);

+ compositor_->vsync_manager()->AddObserver(&begin_frame_source_);

}

void SoftwareBrowserCompositorOutputSurfaceTest::TearDown() {

@@ -109,7 +110,7 @@ std::unique_ptr<content::BrowserCompositorOutputSurface>

SoftwareBrowserCompositorOutputSurfaceTest::CreateSurface(

std::unique_ptr<cc::SoftwareOutputDevice> device) {

return base::MakeUnique<content::SoftwareBrowserCompositorOutputSurface>(

- std::move(device), compositor_->vsync_manager(), &begin_frame_source_,

+ std::move(device), compositor_->vsync_manager(),

base::ThreadTaskRunnerHandle::Get());

}