content/browser/compositor/software_browser_compositor_output_surface.cc - Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface.cc

Issue 2511273002: Decouple BrowserCompositorOutputSurface from BeginFrameSource. (Closed)

Patch Set: Another attempt to fix the crash Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_process_transport_factory.cc ('K') | « content/browser/compositor/software_browser_compositor_output_surface.h ('k') | content/browser/compositor/software_browser_compositor_output_surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/software_browser_compositor_output_surface.cc b/content/browser/compositor/software_browser_compositor_output_surface.cc

index 4e6fd5f83a548d2b678b64c6310fd7e89be60462..6363fe7f0aafe05f0083b2488a6b81f712f9a8c7 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/software_browser_compositor_output_surface.cc

@@ -24,11 +24,8 @@ namespace content {

SoftwareBrowserCompositorOutputSurface::SoftwareBrowserCompositorOutputSurface(

std::unique_ptr<cc::SoftwareOutputDevice> software_device,

const scoped_refptr<ui::CompositorVSyncManager>& vsync_manager,

- cc::SyntheticBeginFrameSource* begin_frame_source,

scoped_refptr<base::SingleThreadTaskRunner> task_runner)

- : BrowserCompositorOutputSurface(std::move(software_device),

- vsync_manager,

- begin_frame_source),

+ : BrowserCompositorOutputSurface(std::move(software_device), vsync_manager),

task_runner_(std::move(task_runner)),

weak_factory_(this) {}