Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2511263002: Switching from CLD3 to CLD2 (Closed)

Created:
4 years, 1 month ago by groby-ooo-7-16
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Switching from CLD3 to CLD2 This is accomplished by: - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1) We are relanding this CL because we haven't had the time to evaluate CLD3 on an additional dataset. Collecting this data took longer than expected. BUG=666042 Review-Url: https://codereview.chromium.org/2504823002 Cr-Commit-Position: refs/heads/master@{#432615} (cherry picked from commit 5c945729a79bd09f1ac542ad2b8baf0a5752152f) Committed: https://chromium.googlesource.com/chromium/src/+/db84fddae052da654954a03a56b88c0d384136e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M third_party/cld/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld_2/BUILD.gn View 3 chunks +55 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
groby-ooo-7-16
4 years, 1 month ago (2016-11-17 21:49:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db84fddae052da654954a03a56b88c0d384136e6.

Powered by Google App Engine
This is Rietveld 408576698