Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2504823002:
Switching from CLD3 to CLD2 (Closed)
|
Created:
4 years, 1 month ago by Anton Bakalov Modified:
4 years, 1 month ago Reviewers:
brettw CC:
chromium-reviews, djweiss1, riesa Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=666042
Committed: https://crrev.com/5c945729a79bd09f1ac542ad2b8baf0a5752152f
Cr-Commit-Position: refs/heads/master@{#432615}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by abakalov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Switching from CLD3 to CLD2 This is accomplished by: - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d... BUG=653881 Committed: https://crrev.com/13cff7269b9e76b0f77ecb94eade1dfee02e6a32 Cr-Commit-Position: refs/heads/master@{#423855} patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1) ========== to ========== Switching from CLD3 to CLD2 Context: We plan on postponing the launch of CLD3 on stable until M56 because collecting and evaluating on an additional dataset took longer than expected. Info about this CL: It was created by running 'git cl patch 2396183002' A link to the patched CL: https://chromiumcodereview.appspot.com/2396183002/ In a follow up CL, I'll just flip the switch in third_party/cld/BUILD.gn Original description of the patched CL: This is accomplished by - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d... patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1) ==========
abakalov@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Can you rewrite the commit message so it makes more sense in the context of looking at a revision log? It should probably start with the original commit message which was fine. Then mention that it's a reland of that other issue (currently it's mentioned twice) and why you're relanding it (new dataset solves problems). The context was useful as a reviewer but next time I'd just write that in the "message" for the email since that doesn't really help the log so much.
Description was changed from ========== Switching from CLD3 to CLD2 Context: We plan on postponing the launch of CLD3 on stable until M56 because collecting and evaluating on an additional dataset took longer than expected. Info about this CL: It was created by running 'git cl patch 2396183002' A link to the patched CL: https://chromiumcodereview.appspot.com/2396183002/ In a follow up CL, I'll just flip the switch in third_party/cld/BUILD.gn Original description of the patched CL: This is accomplished by - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d... patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1) ========== to ========== Switching from CLD3 to CLD2 This is accomplished by: - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d... patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1) This CL is getting landed again because we haven't had the time to evaluate CLD3 on an additional dataset. Collecting this data took longer than expected. BUG= ==========
Description was changed from
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
This CL is getting landed again because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=
==========
to
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=
==========
On 2016/11/16 16:28:45, brettw (ping on IM after 24h) wrote: > LGTM. > > Can you rewrite the commit message so it makes more sense in the context of > looking at a revision log? > > It should probably start with the original commit message which was fine. Then > mention that it's a reland of that other issue (currently it's mentioned twice) > and why you're relanding it (new dataset solves problems). The context was > useful as a reviewer but next time I'd just write that in the "message" for the > email since that doesn't really help the log so much. Thanks, Brett! Good comments as usual.
Description was changed from
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=
==========
to
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=666042
==========
The CQ bit was checked by abakalov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=666042
==========
to
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=666042
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=666042
==========
to
==========
Switching from CLD3 to CLD2
This is accomplished by:
- flipping the flag in third_party/cld/BUILD.gn
- listing explicitly source files in third_party/cld_2/BUILD.gn that
were originally retrieved from the following gyp file which got
removed during the transition away from GYP:
https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d...
patch from issue 2396183002 at patchset 1 (http://crrev.com/2396183002#ps1)
We are relanding this CL because we haven't had the time to
evaluate CLD3 on an additional dataset. Collecting this data
took longer than expected.
BUG=666042
Committed: https://crrev.com/5c945729a79bd09f1ac542ad2b8baf0a5752152f
Cr-Commit-Position: refs/heads/master@{#432615}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5c945729a79bd09f1ac542ad2b8baf0a5752152f Cr-Commit-Position: refs/heads/master@{#432615} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
