Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2511203002: SetBacklightsForcedOff induced BrightnessChanged signal is not user_initiated (Closed)

Created:
4 years, 1 month ago by Qiang(Joe) Xu
Modified:
4 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SetBacklightsForcedOff induced BrightnessChanged signal is not user_initiated SetBacklightsForcedOff is designed to be not user_initiated, thus any call for SetBacklightsForcedOff will not trigger UI bubble. This CL is fixing the wrong usage in TabletPowerButtonControllerTest. BUG=633304 TEST=this cl should not break anything Committed: https://crrev.com/6518074e118be1d1128595f6206d3c1a5db670e6 Cr-Commit-Position: refs/heads/master@{#432999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M ash/system/chromeos/power/tablet_power_button_controller_unittest.cc View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Qiang(Joe) Xu
Hi Daniel, ptal, my apologize for this misusing.
4 years, 1 month ago (2016-11-17 19:28:23 UTC) #3
Daniel Erat
lgtm
4 years, 1 month ago (2016-11-17 20:47:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511203002/1
4 years, 1 month ago (2016-11-17 21:48:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 22:53:59 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:58:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6518074e118be1d1128595f6206d3c1a5db670e6
Cr-Commit-Position: refs/heads/master@{#432999}

Powered by Google App Engine
This is Rietveld 408576698