Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2449)

Unified Diff: ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Issue 2511203002: SetBacklightsForcedOff induced BrightnessChanged signal is not user_initiated (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
diff --git a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc b/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
index e52366d774941bc27646069e3ddc732f5ca17c1c..a6f2b5c0878942d595eef22dc2bf100a79895ea9 100644
--- a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
+++ b/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
@@ -155,12 +155,12 @@ TEST_F(TabletPowerButtonControllerTest,
EXPECT_TRUE(test_api_->ShutdownTimerIsRunning());
EXPECT_FALSE(GetBacklightsForcedOff());
ReleasePowerButton();
- power_manager_client_->SendBrightnessChanged(0, true);
+ power_manager_client_->SendBrightnessChanged(0, false);
EXPECT_FALSE(test_api_->ShutdownTimerIsRunning());
EXPECT_TRUE(GetBacklightsForcedOff());
PressPowerButton();
- power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, true);
+ power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, false);
EXPECT_TRUE(test_api_->ShutdownTimerIsRunning());
EXPECT_FALSE(GetBacklightsForcedOff());
ReleasePowerButton();
@@ -186,11 +186,11 @@ TEST_F(TabletPowerButtonControllerTest,
// Test again when backlights is forced off.
PressPowerButton();
ReleasePowerButton();
- power_manager_client_->SendBrightnessChanged(0, true);
+ power_manager_client_->SendBrightnessChanged(0, false);
EXPECT_TRUE(GetBacklightsForcedOff());
PressPowerButton();
- power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, true);
+ power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, false);
EXPECT_FALSE(GetBacklightsForcedOff());
test_api_->TriggerShutdownTimeout();
EXPECT_TRUE(lock_state_test_api->shutdown_timer_is_running());
@@ -204,7 +204,7 @@ TEST_F(TabletPowerButtonControllerTest, TappingPowerButtonWhenScreenIsIdleOff) {
power_manager_client_->SendBrightnessChanged(0, false);
PressPowerButton();
EXPECT_FALSE(GetBacklightsForcedOff());
- power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, true);
+ power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, false);
ReleasePowerButton();
EXPECT_FALSE(GetBacklightsForcedOff());
}
@@ -245,25 +245,25 @@ TEST_F(TabletPowerButtonControllerTest, ConvertibleOnLaptopMode) {
// KeyEvent should SetBacklightsForcedOff(false).
PressPowerButton();
ReleasePowerButton();
- power_manager_client_->SendBrightnessChanged(0, true);
+ power_manager_client_->SendBrightnessChanged(0, false);
EXPECT_TRUE(GetBacklightsForcedOff());
generator_->PressKey(ui::VKEY_L, ui::EF_NONE);
- power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, true);
+ power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, false);
EXPECT_FALSE(GetBacklightsForcedOff());
// Regular mouse event should SetBacklightsForcedOff(false).
PressPowerButton();
ReleasePowerButton();
- power_manager_client_->SendBrightnessChanged(0, true);
+ power_manager_client_->SendBrightnessChanged(0, false);
EXPECT_TRUE(GetBacklightsForcedOff());
generator_->MoveMouseBy(1, 1);
- power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, true);
+ power_manager_client_->SendBrightnessChanged(kNonZeroBrightness, false);
EXPECT_FALSE(GetBacklightsForcedOff());
// Synthesized mouse event should not SetBacklightsForcedOff(false).
PressPowerButton();
ReleasePowerButton();
- power_manager_client_->SendBrightnessChanged(0, true);
+ power_manager_client_->SendBrightnessChanged(0, false);
EXPECT_TRUE(GetBacklightsForcedOff());
generator_->set_flags(ui::EF_IS_SYNTHESIZED);
generator_->MoveMouseBy(1, 1);
@@ -285,7 +285,7 @@ TEST_F(TabletPowerButtonControllerTest, ConvertibleOnMaximizeMode) {
PressPowerButton();
ReleasePowerButton();
- power_manager_client_->SendBrightnessChanged(0, true);
+ power_manager_client_->SendBrightnessChanged(0, false);
EXPECT_TRUE(GetBacklightsForcedOff());
generator_->PressKey(ui::VKEY_L, ui::EF_NONE);
EXPECT_TRUE(GetBacklightsForcedOff());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698