mus: Split the gpu client-lib into a separate component.

mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
TBR=ben@ for trivial #include update in content/renderer

Committed: https://crrev.com/7132ff590b6dc39d244c578899985df7c63797f9
Cr-Commit-Position: refs/heads/master@{#433233}

[sadrul, 2016-11-18 03:59:06]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 04:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:08:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sadrul, 2016-11-18 04:13:30]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 04:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:20:17]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-11-18 04:28:10]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 04:28:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-18 04:54:28]

Description was changed from

==========
mus: Split the gpu client-lib into a separate component.

...

BUG=643746
==========

to

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
==========

[sadrul, 2016-11-18 04:56:23]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 07:02:33]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-18 16:44:25]

LGTM

[sadrul, 2016-11-18 17:25:49]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:26:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-18 17:31:33]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2016-11-18 17:31:34]

+ben@ for trivial header update in content/renderer (will TBR)

[sadrul, 2016-11-18 17:31:59]

Description was changed from

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
==========

to

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
TBR=ben@ for trivial #include update in content/renderer
==========

[commit-bot: I haz the power, 2016-11-18 17:44:57]

Description was changed from

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
TBR=ben@ for trivial #include update in content/renderer
==========

to

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
TBR=ben@ for trivial #include update in content/renderer
==========

[commit-bot: I haz the power, 2016-11-18 17:44:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-18 17:49:28]

Description was changed from

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
TBR=ben@ for trivial #include update in content/renderer
==========

to

==========
mus: Split the gpu client-lib into a separate component.

Create //services/ui/public/cpp/gpu component to talk to the mus
window server for doing gpu related work (e.g. making connection,
allocating gpu memory etc.). Use this same component from both
the aura and the non-aura client libs, so that we don't have to
maintain the same code in both places.

BUG=643746
TBR=ben@ for trivial #include update in content/renderer

Committed: https://crrev.com/7132ff590b6dc39d244c578899985df7c63797f9
Cr-Commit-Position: refs/heads/master@{#433233}
==========

[commit-bot: I haz the power, 2016-11-18 17:49:30]

Patchset 4 (id:??) landed as
https://crrev.com/7132ff590b6dc39d244c578899985df7c63797f9
Cr-Commit-Position: refs/heads/master@{#433233}

[mfomitchev, 2016-11-18 22:02:33]

mfomitchev@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[mfomitchev, 2016-11-18 22:02:34]

https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
File services/ui/public/cpp/gpu/gpu_service.cc (right):

https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/gpu_service.cc:14: #include
"services/ui/common/switches.h"
nit: I don't think this is needed (was removed in aura)

https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
File services/ui/public/cpp/gpu/gpu_service.h (right):

https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
services/ui/public/cpp/gpu/gpu_service.h:18: #include
"gpu/ipc/common/gpu_info.mojom.h"
nit: I don't think this is needed (was removed in aura)

[sadrul, 2016-11-20 03:01:00]

On 2016/11/18 22:02:34, mfomitchev wrote:
>
https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
> File services/ui/public/cpp/gpu/gpu_service.cc (right):
> 
>
https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
> services/ui/public/cpp/gpu/gpu_service.cc:14: #include
> "services/ui/common/switches.h"
> nit: I don't think this is needed (was removed in aura)
> 
>
https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
> File services/ui/public/cpp/gpu/gpu_service.h (right):
> 
>
https://codereview.chromium.org/2511143004/diff/60001/services/ui/public/cpp/...
> services/ui/public/cpp/gpu/gpu_service.h:18: #include
> "gpu/ipc/common/gpu_info.mojom.h"
> nit: I don't think this is needed (was removed in aura)

Addressed these in https://codereview.chromium.org/2516843002/