[Mac] Omnibox icons active states

chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
index 3297ebe4f1b6406a4fd666d95b5d78ef8abf055d..86b62a893fe863f7eeb289563936501281613003 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h
@@ -24,6 +24,7 @@ class Browser;
 class BrowserActionsContainerViewSizeDelegate;
 @class BrowserActionsController;
 class CommandUpdater;
+class LocationBarDecoration;
 class LocationBarViewMac;
 @class MenuButton;
 class Profile;
@@ -165,8 +166,14 @@ class NotificationBridge;
 // Point on the save credit card icon for the save credit card bubble.
 - (NSPoint)saveCreditCardBubblePoint;
 
-// Point on the translate icon for the Translate bubble.
-- (NSPoint)translateBubblePoint;
+// Point on the given |decoration| for its associated bubble.
+- (NSPoint)bubblePointForDecoration:(LocationBarDecoration*)decoration;
+
+// Returns the star icon decoration in the omnibox.
+- (LocationBarDecoration*)bookmarkDecoration;

[Robert Sesek, 2016/11/21 19:28:23]

Per the previous comment, by injecting the LocationBarDecoration into the
OmniboxIconBubbleController I think you may not need to expose these accessors.

[spqchan, 2016/11/23 22:58:54]

The bubble classes still need to access the decorations. I made a change though
so they are pulling the values from locationBarViewMac directly instead of
toolbarController. 

+
+// Returns the translate icon decoration in the omnibox.
+- (LocationBarDecoration*)translateDecoration;
 
 // Returns the desired toolbar height for the given compression factor.
 - (CGFloat)desiredHeightForCompression:(CGFloat)compressByHeight;