[Mac] Omnibox icons active states

chrome/browser/ui/cocoa/toolbar/toolbar_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
 #include "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"
 #import "chrome/browser/ui/cocoa/url_drop_target.h"
 #import "chrome/browser/ui/cocoa/view_resizer.h"
 #include "components/prefs/pref_member.h"
 #import "ui/base/cocoa/tracking_area.h"
 
 @class AutocompleteTextField;
 @class AutocompleteTextFieldEditor;
 @class BackForwardMenuController;
 class Browser;
 @class BrowserActionsContainerView;
 class BrowserActionsContainerViewSizeDelegate;
 @class BrowserActionsController;
 class CommandUpdater;
+class LocationBarDecoration;
 class LocationBarViewMac;
 @class MenuButton;
 class Profile;
 @class ReloadButton;
 @class ToolbarButton;
 @class AppMenuController;
 
 namespace content {
 class WebContents;
 }
@@ skipping 121 matching lines @@
 // ignored. This changes the behavior of other methods, like |-view|.
 - (void)setHasToolbar:(BOOL)toolbar hasLocationBar:(BOOL)locBar;
 
 // Point on the star icon for the bookmark bubble to be - in the
 // associated window's coordinate system.
 - (NSPoint)bookmarkBubblePoint;
 
 // Point on the save credit card icon for the save credit card bubble.
 - (NSPoint)saveCreditCardBubblePoint;
 
-// Point on the translate icon for the Translate bubble.
-- (NSPoint)translateBubblePoint;
+// Point on the given |decoration| for its associated bubble.
+- (NSPoint)bubblePointForDecoration:(LocationBarDecoration*)decoration;
+
+// Returns the star icon decoration in the omnibox.
+- (LocationBarDecoration*)bookmarkDecoration;

[Robert Sesek, 2016/11/21 19:28:23]

Per the previous comment, by injecting the LocationBarDecoration into the
OmniboxIconBubbleController I think you may not need to expose these accessors.

[spqchan, 2016/11/23 22:58:54]

The bubble classes still need to access the decorations. I made a change though
so they are pulling the values from locationBarViewMac directly instead of
toolbarController. 

+
+// Returns the translate icon decoration in the omnibox.
+- (LocationBarDecoration*)translateDecoration;
 
 // Returns the desired toolbar height for the given compression factor.
 - (CGFloat)desiredHeightForCompression:(CGFloat)compressByHeight;
 
 // Set the opacity of the divider (the line at the bottom) *if* we have a
 // |ToolbarView| (0 means don't show it); no-op otherwise.
 - (void)setDividerOpacity:(CGFloat)opacity;
 
 // Create and add the Browser Action buttons to the toolbar view.
 - (void)createBrowserActionButtons;
@@ skipping 19 matching lines @@
 @interface ToolbarController(PrivateTestMethods)
 // Returns an array of views in the order of the outlets above.
 - (NSArray*)toolbarViews;
 - (void)showOptionalHomeButton;
 - (void)installAppMenu;
 // Return a hover button for the current event.
 - (NSButton*)hoverButtonForEvent:(NSEvent*)theEvent;
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_TOOLBAR_TOOLBAR_CONTROLLER_H_