Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Issue 25110005: Composited fixed-pos element should still cause repaints if it paintsIntoCompositedAncestor (Closed)

Created:
7 years, 2 months ago by shawnsingh
Modified:
7 years, 2 months ago
Reviewers:
enne (OOO)
CC:
blink-reviews, blink-layers+watch_chromium.org, kenneth.christiansen
Visibility:
Public.

Description

Composited fixed-pos element should still cause repaints if it paintsIntoCompositedAncestor A composited fixed-position element may still actually be set to paint into its composited ancestor, even though it has its own backing. ScrollingCoordinator and FrameView were not recognizing this situation and thus the fixed-position element did not repaint, appearing to be attached to the scrolling contents rather than the viewport. This patch makes the FrameView and ScrollingCoordinator aware of the scenario so that main-thread scrolling is forced and repaints occur. This patch is an exact re-land of 157920, which was reverted in 158540. It was reverted only because it had a very badly misleading description. TBR=enne@chromium.org BUG=151734 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -3 lines) Patch
A LayoutTests/compositing/repaint/fixed-pos-with-composited-child.html View 1 chunk +74 lines, -0 lines 0 comments Download
A LayoutTests/compositing/repaint/fixed-pos-with-composited-child-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
M Source/core/page/FrameView.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/25110005/1
7 years, 2 months ago (2013-09-30 18:11:25 UTC) #1
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 18:11:38 UTC) #2
Message was sent while issue was closed.
Change committed as 158541

Powered by Google App Engine
This is Rietveld 408576698