Source/core/page/FrameView.cpp - Issue 25110005: Composited fixed-pos element should still cause repaints if it paintsIntoCompositedAncestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FrameView.cpp

Issue 25110005: Composited fixed-pos element should still cause repaints if it paintsIntoCompositedAncestor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/compositing/repaint/fixed-pos-with-composited-child-expected.txt ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/FrameView.cpp

diff --git a/Source/core/page/FrameView.cpp b/Source/core/page/FrameView.cpp

index 343bbb47f3cb11f6d67582be68e879639891c76f..7a898dfcce0d99adab4a31de5b2092eab53556c1 100644

--- a/Source/core/page/FrameView.cpp

+++ b/Source/core/page/FrameView.cpp

@@ -1354,13 +1354,16 @@ bool FrameView::scrollContentsFastPath(const IntSize& scrollDelta, const IntRect

if (!renderer->style()->hasViewportConstrainedPosition())

continue;

- if (renderer->isComposited())

- continue;

// Fixed items should always have layers.

ASSERT(renderer->hasLayer());

RenderLayer* layer = toRenderBoxModelObject(renderer)->layer();

+ // Composited layers may still actually paint into their ancestor.

+ // If that happens, the viewport constrained object needs to be

+ // repainted on scroll.

+ if (layer->isComposited() && !layer->backing()->paintsIntoCompositedAncestor())

+ continue;

if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotCompositedForBoundsOutOfView

|| layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotCompositedForNoVisibleContent) {

// Don't invalidate for invisible fixed layers.