Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2510953002: MD Settings: alphabetize targets in settings main compiled_resources2.gyp (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: alphabetize targets in settings main compiled_resources2.gyp R=tommycli@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/01dc9df9311ec4a302ea1928e3a7c6755251e901 Cr-Commit-Position: refs/heads/master@{#432909}

Patch Set 1 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M chrome/browser/resources/settings/compiled_resources2.gyp View 3 chunks +41 lines, -41 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Dan Beam
4 years, 1 month ago (2016-11-16 23:33:25 UTC) #3
tommycli
lgtm
4 years, 1 month ago (2016-11-17 16:58:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510953002/20001
4 years, 1 month ago (2016-11-17 17:45:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-17 17:57:19 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 18:09:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01dc9df9311ec4a302ea1928e3a7c6755251e901
Cr-Commit-Position: refs/heads/master@{#432909}

Powered by Google App Engine
This is Rietveld 408576698