MD Settings: create a shared handler/browser proxy to control extensions

MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265

[Dan Beam, 2016-11-16 03:37:32]

Description was changed from

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=dpapad@chromium.org
BUG=614265
==========

to

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-16 03:40:48]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-11-16 03:40:52]

https://codereview.chromium.org/2509543002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
(left):

https://codereview.chromium.org/2509543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html:6:
<link rel="import"
href="/search_engines_page/search_engines_browser_proxy.html">
i can leave this if you want... it's only needed for typechecking

[Dan Beam, 2016-11-16 03:40:56]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 03:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 04:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:13:49]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Dan Beam, 2016-11-16 19:56:22]

Description was changed from

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-11-16 19:56:23]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org
- dpapad@chromium.org

[Dan Beam, 2016-11-16 19:56:58]

+tommycli@ for review, moving dpapad@ to CC

[tommycli, 2016-11-16 21:34:35]

lgtm. This looks like it just splits the Browser Proxy and C++ handler into two
right?

https://codereview.chromium.org/2509543002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
(left):

https://codereview.chromium.org/2509543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html:6:
<link rel="import"
href="/search_engines_page/search_engines_browser_proxy.html">
On 2016/11/16 03:40:52, Dan Beam wrote:
> i can leave this if you want... it's only needed for typechecking

No need IMO. Good as the patch has it.

[Dan Beam, 2016-11-16 21:57:13]

On 2016/11/16 21:34:35, tommycli wrote:
> lgtm. This looks like it just splits the Browser Proxy and C++ handler into
two
> right?

yes, i'm adding a couple of uses in upcoming CLs in which I add an extension
controlled UI with a "DISABLE" button and a link that calls manageExtension()

[Dan Beam, 2016-11-16 23:18:52]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 23:19:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 00:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:57:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dan Beam, 2016-11-17 01:04:35]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 01:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-17 02:26:25]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-11-17 02:26:29]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-11-17 02:26:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2509543002/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2016-11-17 02:27:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-17 02:45:43]

Description was changed from

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265
==========

[commit-bot: I haz the power, 2016-11-17 03:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:15:33]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[Dan Beam, 2016-11-17 04:14:29]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:48:04]

Description was changed from

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265
==========

to

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265

Committed: https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d
Cr-Commit-Position: refs/heads/master@{#432742}
==========

[commit-bot: I haz the power, 2016-11-17 04:48:05]

Patchset 2 (id:??) landed as
https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d
Cr-Commit-Position: refs/heads/master@{#432742}

[Dan Beam, 2016-11-17 04:52:22]

Description was changed from

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265

Committed: https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d
Cr-Commit-Position: refs/heads/master@{#432742}
==========

to

==========
MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG=614265
==========

[Dan Beam, 2016-11-17 04:52:23]

Committed patchset #2 (id:40001) to pending queue manually as
1daa8403b10d5511dcd865c7140b25945e8e974f (presubmit successful).