Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2510923003:
Widen sandbox rules to allow access to downloaded Sierra fonts (Closed)
DescriptionModify sandbox configuration to allow downloaded fonts
macOS sierra provides font that are downloaded and placed in a location
separate from the well known /Library/Fonts and
/System/Library/Fonts. We need to add this sandbox option to
dynamically allow access to those fonts.
BUG=662686
Committed: https://crrev.com/18e5f71764a46d66657b7ddec9c836575b7c6799
Cr-Commit-Position: refs/heads/master@{#439564}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Modify Mac sandbox configuration to permit downloaded fonts #Messages
Total messages: 27 (17 generated)
drott@chromium.org changed reviewers: + rsesek@chromium.org
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2510923003/diff/1/content/renderer/renderer.sb File content/renderer/renderer.sb (right): https://codereview.chromium.org/2510923003/diff/1/content/renderer/renderer.s... content/renderer/renderer.sb:12: (allow file-read* (regex #"^/System/Library/Assets/com_apple_MobileAsset_Font3($|/)")) Can you add a comment with the bug URL?
dannyvarano99@gmail.com changed reviewers: + dannyvarano99@gmail.com
lgtm
lgtm
lgtm
Description was changed from ========== Widen sandbox rules to allow access to downloaded Sierra fonts macOS sierra provides font that are downloaded and placed in a location separate from the well known /Library/Fonts and /System/Library/Fonts. We need to add this directory to the renderer file read access sandbox exceptions in order to match against those fonts. BUG=662686 ========== to ========== Modify sandbox configuration to allow downloaded fonts macOS sierra provides font that are downloaded and placed in a location separate from the well known /Library/Fonts and /System/Library/Fonts. We need to add this sandbox option to dynamically allow access to those fonts. BUG=662686 ==========
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
drott@chromium.org changed reviewers: - dannyvarano99@gmail.com
Robert, I updated this with the additional information I had received. Could you take another look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by drott@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dannyvarano99@gmail.com Link to the patchset: https://codereview.chromium.org/2510923003/#ps20001 (title: "Modify Mac sandbox configuration to permit downloaded fonts")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482181630042690,
"parent_rev": "1453c92c342dd7d5239163efc4bfa65814c8498f", "commit_rev":
"ea0ed8ac58c353457b21f875ae13bc2a3c7602a1"}
Message was sent while issue was closed.
Description was changed from ========== Modify sandbox configuration to allow downloaded fonts macOS sierra provides font that are downloaded and placed in a location separate from the well known /Library/Fonts and /System/Library/Fonts. We need to add this sandbox option to dynamically allow access to those fonts. BUG=662686 ========== to ========== Modify sandbox configuration to allow downloaded fonts macOS sierra provides font that are downloaded and placed in a location separate from the well known /Library/Fonts and /System/Library/Fonts. We need to add this sandbox option to dynamically allow access to those fonts. BUG=662686 Review-Url: https://codereview.chromium.org/2510923003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Modify sandbox configuration to allow downloaded fonts macOS sierra provides font that are downloaded and placed in a location separate from the well known /Library/Fonts and /System/Library/Fonts. We need to add this sandbox option to dynamically allow access to those fonts. BUG=662686 Review-Url: https://codereview.chromium.org/2510923003 ========== to ========== Modify sandbox configuration to allow downloaded fonts macOS sierra provides font that are downloaded and placed in a location separate from the well known /Library/Fonts and /System/Library/Fonts. We need to add this sandbox option to dynamically allow access to those fonts. BUG=662686 Committed: https://crrev.com/18e5f71764a46d66657b7ddec9c836575b7c6799 Cr-Commit-Position: refs/heads/master@{#439564} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/18e5f71764a46d66657b7ddec9c836575b7c6799 Cr-Commit-Position: refs/heads/master@{#439564} |
