Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 2510883002: DevTools: all swatches should have a default focused element (Closed)
Patch Set: a Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
index 7d27e2a0479f642d69ae58ead704421972410b3e..aa00b773af2cb4ea5909d38456827a392c995520 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js
@@ -83,8 +83,11 @@ UI.Popover = class extends UI.Widget {
this._contentElement = contentElement;
// This should not happen, but we hide previous popup to be on the safe side.
- if (UI.Popover._popover)
+ var restoreFocus;
+ if (UI.Popover._popover) {
+ restoreFocus = UI.Popover._popover.hasFocus();
UI.Popover._popover.hide();
+ }
UI.Popover._popover = this;
var document = anchor instanceof Element ? anchor.ownerDocument : contentElement.ownerDocument;
@@ -98,6 +101,8 @@ UI.Popover = class extends UI.Widget {
window.addEventListener('resize', this._hideBound, false);
document.body.appendChild(this._containerElement);
super.show(this._containerElement);
+ if (restoreFocus && view)
+ view.focus();
dgozman 2016/11/17 01:29:50 How do you focus view before showing it in line 10
luoe 2016/11/17 21:38:08 Ahh, good point. We should restore focus after th
if (view)
view.show(this._contentDiv);

Powered by Google App Engine
This is Rietveld 408576698