DevTools: all swatches should have a default focused element

third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js

Index: third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js
index 9ce5442eea3656ab7a3bf57397c7b25de71829bd..97549c01979f31f3a5e8fd1bfe6ba62b1c1ebc26 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js
@@ -53,6 +53,7 @@ UI.SwatchPopoverHelper = class extends Common.Object {
     this._view = view;
     this._hiddenCallback = hiddenCallback;
     this.reposition();
+    view.focus();

[dgozman, 2016/11/17 01:29:50]

Shouldn't call to popover.showView handle this?

[luoe, 2016/11/17 21:38:08]

I don't think so.  Not all popovers need to take focus for themselves.  For
swatches, I think it's always reasonable for them to steal focus because
swatches open for editing, which requires user interaction.

Placing .focus() in the general popover.showView will affect popovers shown on
hover, e.g. hovering over rows/blocks in Network, Timeline, Animations panel
which are meant to be ephemeral and hide on mouseout.  If we put .focus() there,
we'd also need to put a focus restorer there, which isn't necessary.

 
     var document = this._popover.element.ownerDocument;
     document.addEventListener('mousedown', this._hideProxy, false);