A decimal integer literal with a leading 0 is now an error in strict mode.

A decimal integer literal with a leading 0 is now an error in strict mode.

We're still collecting use counter data for this situation.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/93b87c89f28163caea5a72942e06394e7200cbe7
Cr-Commit-Position: refs/heads/master@{#41563}

[jwolfe, 2016-11-17 23:50:18]

Description was changed from

==========
A number literal with a leading 0 is now an error in strict mode.

Also changed these error messages:

For number literals:
- Octal literals are not allowed in strict mode.
+ Number literals must not have a '0' prefix in strict mode.

For escape sequences in normal strings:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

For escape sequences in template strings:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

These changes were because "08" is not actually an octal literal,
because "'\11'" doesn't have a '0' prefix, and because "octal escape
sequence" is a more correct name than "octal literal".

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
A number literal with a leading 0 is now an error in strict mode.

Also changed these error messages:

For number literals:
- Octal literals are not allowed in strict mode.
+ Number literals must not have a '0' prefix in strict mode.

For escape sequences in normal strings:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

For escape sequences in template strings:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

These changes were because "08" is not actually an octal literal,
because "'\11'" doesn't have a '0' prefix, and because "octal escape
sequence" is a more correct name than "octal literal".

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jwolfe, 2016-11-17 23:50:18]

jwolfe@igalia.com changed reviewers:
+ littledan@chromium.org

[jwolfe, 2016-11-17 23:51:20]

Could someone please run a dry run to test the impact of this change on the
layout tests? I suspect some expected output there will need updates.

[Dan Ehrenberg, 2016-11-18 08:14:25]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 08:14:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 09:08:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 09:08:13]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-11-18 17:13:51]

Could you split this into two patches, one for changing the error messages, and
one for turning this error on? This way, if we end up having to revert one, we
wouldn't also be reverting the other. It will also make the test changes easier
to review, and look through later as archaeology.

https://codereview.chromium.org/2510873005/diff/1/src/messages.h
File src/messages.h (right):

https://codereview.chromium.org/2510873005/diff/1/src/messages.h#newcode598
src/messages.h:598: "Number literals must not have a '0' prefix in strict
mode.")              \
This isn't quite right. 0b1 is a number literal allowed in strict mode, for
example...

https://codereview.chromium.org/2510873005/diff/1/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2510873005/diff/1/src/parsing/parser-base.h#n...
src/parsing/parser-base.h:865: DCHECK_NE(message, MessageTemplate::kNone);
IMO it wouldn't hurt to continue updating the UseCounter here, just to be sure
it doesn't break a bunch of sites in the future, but maintaining the counters 
is optional and not something we've done consistently in the past.

[jwolfe, 2016-12-02 22:01:43]

On 2016/11/18 17:13:51, Dan Ehrenberg wrote:
> Could you split this into two patches...
See: https://codereview.chromium.org/2551633002/

[jwolfe, 2016-12-07 18:23:31]

Description was changed from

==========
A number literal with a leading 0 is now an error in strict mode.

Also changed these error messages:

For number literals:
- Octal literals are not allowed in strict mode.
+ Number literals must not have a '0' prefix in strict mode.

For escape sequences in normal strings:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

For escape sequences in template strings:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

These changes were because "08" is not actually an octal literal,
because "'\11'" doesn't have a '0' prefix, and because "octal escape
sequence" is a more correct name than "octal literal".

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
A number literal with a leading 0 is now an error in strict mode.

Also changed these error messages:

For number literals:
- Octal literals are not allowed in strict mode.
+ Number literals must not have a '0' prefix in strict mode.

For escape sequences in normal strings:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

For escape sequences in template strings:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

These changes were because "08" is not actually an octal literal,
because "'\11'" doesn't have a '0' prefix, and because "octal escape
sequence" is a more correct name than "octal literal".

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jwolfe, 2016-12-07 18:46:51]

Description was changed from

==========
A number literal with a leading 0 is now an error in strict mode.

Also changed these error messages:

For number literals:
- Octal literals are not allowed in strict mode.
+ Number literals must not have a '0' prefix in strict mode.

For escape sequences in normal strings:
- Octal literals are not allowed in strict mode.
+ Octal escape sequences are not allowed in strict mode.

For escape sequences in template strings:
- Octal literals are not allowed in template strings.
+ Octal escape sequences are not allowed in template strings.

These changes were because "08" is not actually an octal literal,
because "'\11'" doesn't have a '0' prefix, and because "octal escape
sequence" is a more correct name than "octal literal".

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
A decimal integer literal with a leading 0 is now an error in strict mode.

We're still collecting use counter data for this situation.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jwolfe, 2016-12-07 18:48:42]

PTAL

[Dan Ehrenberg, 2016-12-07 19:10:26]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 19:10:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-12-07 19:12:35]

lgtm

Looks great, good message and clean implementation. Let's take a look at the
Blink trybot before pressing the commit button though.

[adamk, 2016-12-07 19:16:03]

On 2016/12/07 19:12:35, Dan Ehrenberg wrote:
> lgtm
> 
> Looks great, good message and clean implementation. Let's take a look at the
> Blink trybot before pressing the commit button though.

FWIW, seems like pressing the commit button should at least be "safe" if you
have that CQ_INCLUDE_TRYBOTS line, right?

[commit-bot: I haz the power, 2016-12-07 19:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 19:55:54]

Dry run: This issue passed the CQ dry run.

[jwolfe, 2016-12-07 20:06:58]

Everything passed the dry run. Looks like this is good to go.

[jwolfe, 2016-12-07 20:07:24]

The CQ bit was checked by jwolfe@igalia.com

[commit-bot: I haz the power, 2016-12-07 20:07:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 20:09:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481141244156740,
"parent_rev": "12567a28be95fc571d43488598004981f47d8cca", "commit_rev":
"06c897e0e53cc9248b344871aa8f4c5a67c6976a"}

[commit-bot: I haz the power, 2016-12-07 20:09:30]

Description was changed from

==========
A decimal integer literal with a leading 0 is now an error in strict mode.

We're still collecting use counter data for this situation.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
A decimal integer literal with a leading 0 is now an error in strict mode.

We're still collecting use counter data for this situation.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-12-07 20:09:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 20:09:47]

Description was changed from

==========
A decimal integer literal with a leading 0 is now an error in strict mode.

We're still collecting use counter data for this situation.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
A decimal integer literal with a leading 0 is now an error in strict mode.

We're still collecting use counter data for this situation.

BUG=v8:4973
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/93b87c89f28163caea5a72942e06394e7200cbe7
Cr-Commit-Position: refs/heads/master@{#41563}
==========

[commit-bot: I haz the power, 2016-12-07 20:09:47]

Patchset 2 (id:??) landed as
https://crrev.com/93b87c89f28163caea5a72942e06394e7200cbe7
Cr-Commit-Position: refs/heads/master@{#41563}