Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2446)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/vr/android/gvr/gvr_delegate.h

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « chrome/browser/android/vr_shell/vr_shell_delegate.cc ('k') | device/vr/android/gvr/gvr_device.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/android/gvr/gvr_delegate.h
diff --git a/device/vr/android/gvr/gvr_delegate.h b/device/vr/android/gvr/gvr_delegate.h
index 3b57a77c2ad43d0e15abfcdc87d0c6d0eaba5102..dd1424d392cbab8d8e2a35d232e4174ce7d5b35d 100644
--- a/device/vr/android/gvr/gvr_delegate.h
+++ b/device/vr/android/gvr/gvr_delegate.h
@@ -33,8 +33,9 @@ class DEVICE_VR_EXPORT GvrDelegateProvider {
static void SetInstance(GvrDelegateProvider* delegate_provider);
static GvrDelegateProvider* GetInstance();
- virtual bool RequestWebVRPresent(
- base::WeakPtr<GvrDeviceProvider> device_provider) = 0;
+ virtual void RequestWebVRPresent(
+ base::WeakPtr<GvrDeviceProvider> device_provider,
+ const base::Callback<void(bool)>& callback) = 0;
virtual void ExitWebVRPresent() = 0;
virtual base::WeakPtr<GvrDelegate> GetNonPresentingDelegate() = 0;
virtual void DestroyNonPresentingDelegate() = 0;
« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « chrome/browser/android/vr_shell/vr_shell_delegate.cc ('k') | device/vr/android/gvr/gvr_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698