device/vr/android/gvr/gvr_device.h - Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/android/gvr/gvr_device.h

Issue 2510873003: Clean up WebVR RequestPresent and make callback asynchronous. (Closed)

Patch Set: Address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/android/gvr/gvr_device.h

diff --git a/device/vr/android/gvr/gvr_device.h b/device/vr/android/gvr/gvr_device.h

index e26d7d06972e60da7d420b036f21ad60e9bca082..f1f0f4e13db10263b84c4c441093aaab8e105a58 100644

--- a/device/vr/android/gvr/gvr_device.h

+++ b/device/vr/android/gvr/gvr_device.h

@@ -29,7 +29,8 @@ class GvrDevice : public VRDevice {

mojom::VRPosePtr GetPose() override;

void ResetPose() override;

- bool RequestPresent(bool secure_origin) override;

+ void RequestPresent(const base::Callback<void(bool)>& callback) override;

+ void SetSecureOrigin(bool secure_origin) override;

void ExitPresent() override;

void SubmitFrame(mojom::VRPosePtr pose) override;