Add TODO to BrowsingHistoryService regarding WebHistory deletion.

Add TODO to BrowsingHistoryService regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org

Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Committed: https://crrev.com/e19052772536e4905318016a9be605baa72f99de
Cr-Original-Commit-Position: refs/heads/master@{#433480}
Cr-Commit-Position: refs/heads/master@{#433771}

[calamity, 2016-11-18 05:15:11]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=True
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=true
==========

[calamity, 2016-11-18 05:16:39]

calamity@chromium.org changed reviewers:
+ msramek@chromium.org

[msramek, 2016-11-18 08:28:41]

LGTM, thanks a lot for the followup!

[calamity, 2016-11-21 00:35:20]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-11-21 00:35:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 00:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 00:42:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[calamity, 2016-11-21 04:37:34]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 04:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 04:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 04:40:58]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-11-21 05:49:44]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-11-21 05:49:45]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2510823005/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-21 05:49:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 05:53:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479707384837550,
"parent_rev": ["eaafb9962e5431838e3018edd2a5572610e2beab", null], "commit_rev":
["2bc6a7d54c38d634f2cce9d7040deeb51085997f", null]}

[commit-bot: I haz the power, 2016-11-21 05:53:43]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=true
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=true
==========

[commit-bot: I haz the power, 2016-11-21 05:53:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 05:56:46]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=true
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=true

Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

[commit-bot: I haz the power, 2016-11-21 05:56:47]

Patchset 2 (id:??) landed as
https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}

[Matt Giuca, 2016-11-21 06:12:31]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2516283002/ by mgiuca@chromium.org.

The reason for reverting is: Compile failed (adds a new method definition
without a declaration).

BUG=667190.

[calamity, 2016-11-21 06:31:41]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
NOTRY=true

Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None


Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

[calamity, 2016-11-22 01:34:28]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None


Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org


Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

[calamity, 2016-11-22 01:35:36]

calamity@chromium.org changed reviewers:
+ sdefresne@chromium.org

[calamity, 2016-11-22 01:35:36]

TBRing sdefresne@

[calamity, 2016-11-22 01:36:04]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 01:36:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 02:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 02:30:57]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-11-22 03:19:32]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-11-22 03:19:32]

The patchset sent to the CQ was uploaded after l-g-t-m from msramek@chromium.org
Link to the patchset: https://codereview.chromium.org/2510823005/#ps40001
(title: "rebase properly")

[commit-bot: I haz the power, 2016-11-22 03:19:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:25:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479784772680810,
"parent_rev": "f74cb9a1604d1364314893e38f8462181fd4074a", "commit_rev":
"c7089c71b827cb6fd7473997859478672e39d5b0"}

[commit-bot: I haz the power, 2016-11-22 03:25:56]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org


Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org


Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

[commit-bot: I haz the power, 2016-11-22 03:25:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 03:28:45]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org


Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Cr-Commit-Position: refs/heads/master@{#433480}
==========

to

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org

Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Committed: https://crrev.com/e19052772536e4905318016a9be605baa72f99de
Cr-Original-Commit-Position: refs/heads/master@{#433480}
Cr-Commit-Position: refs/heads/master@{#433771}
==========

[commit-bot: I haz the power, 2016-11-22 03:28:46]

Patchset 3 (id:??) landed as
https://crrev.com/e19052772536e4905318016a9be605baa72f99de
Cr-Commit-Position: refs/heads/master@{#433771}

[calamity, 2016-11-22 04:13:28]

Description was changed from

==========
Add TODO to BrowsingHistoryHandler regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org

Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Committed: https://crrev.com/e19052772536e4905318016a9be605baa72f99de
Cr-Original-Commit-Position: refs/heads/master@{#433480}
Cr-Commit-Position: refs/heads/master@{#433771}
==========

to

==========
Add TODO to BrowsingHistoryService regarding WebHistory deletion.

This CL is a followup to https://codereview.chromium.org/2455503004/.

BUG=None
TBR=sdefresne@chromium.org

Committed: https://crrev.com/59b816025d660a3e4e42744654350b0d3145c7e7
Committed: https://crrev.com/e19052772536e4905318016a9be605baa72f99de
Cr-Original-Commit-Position: refs/heads/master@{#433480}
Cr-Commit-Position: refs/heads/master@{#433771}
==========

[sdefresne, 2016-11-22 11:39:57]

lgtm