Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: chrome/browser/history/browsing_history_service.cc

Issue 2510823005: Add TODO to BrowsingHistoryService regarding WebHistory deletion. (Closed)
Patch Set: rebase properly Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/browsing_history_service.cc
diff --git a/chrome/browser/history/browsing_history_service.cc b/chrome/browser/history/browsing_history_service.cc
index 9f257c9f59d756e88ceb7793ae40c1775bcc943d..a02601a60e744214f4962fd282d500832cc79a29 100644
--- a/chrome/browser/history/browsing_history_service.cc
+++ b/chrome/browser/history/browsing_history_service.cc
@@ -575,6 +575,8 @@ void BrowsingHistoryService::OnURLsDeleted(
}
void BrowsingHistoryService::OnWebHistoryDeleted() {
+ // TODO(calamity): Only ignore web history deletions when they are actually
+ // initiated by us, rather than ignoring them whenever we are deleting.
if (!has_pending_delete_request_)
handler_->HistoryDeleted();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698