ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm - Issue 2510803003: Pass RapporService to content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

Issue 2510803003: Pass RapporService to content/browser/ (Closed)

Patch Set: Fix more compile errors in JNI files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/security_interstitials/core/metrics_helper.cc ('K') | « ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h ('k') | ios/chrome/browser/prefs/browser_prefs.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm b/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

index e5693393ed5e36fce44c8e2430980cce497bfcd6..1afc1478a7559fbab752a0b44d55c8452526cec9 100644

--- a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm

@@ -10,7 +10,7 @@

#include "components/metrics/enabled_state_provider.h"

#include "components/metrics/metrics_state_manager.h"

#include "components/prefs/pref_service.h"

-#include "components/rappor/rappor_service.h"

+#include "components/rappor/rappor_service_impl.h"

#include "components/variations/service/variations_service.h"

#include "ios/chrome/browser/application_context.h"

#include "ios/chrome/browser/chrome_switches.h"

@@ -58,10 +58,10 @@ IOSChromeMetricsServicesManagerClient::IOSChromeMetricsServicesManagerClient(

IOSChromeMetricsServicesManagerClient::

~IOSChromeMetricsServicesManagerClient() = default;

-std::unique_ptr<rappor::RapporService>

-IOSChromeMetricsServicesManagerClient::CreateRapporService() {

+std::unique_ptr<rappor::RapporServiceImpl>

+IOSChromeMetricsServicesManagerClient::CreateRapporServiceImpl() {

DCHECK(thread_checker_.CalledOnValidThread());

- return base::MakeUnique<rappor::RapporService>(

+ return base::MakeUnique<rappor::RapporServiceImpl>(

local_state_, base::Bind(&::IsOffTheRecordSessionActive));

}