ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h - Issue 2510803003: Pass RapporService to content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h

Issue 2510803003: Pass RapporService to content/browser/ (Closed)

Patch Set: Fix more compile errors in JNI files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/security_interstitials/core/metrics_helper.cc ('K') | « ios/chrome/browser/ios_chrome_main_parts.mm ('k') | ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h

diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h b/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h

index 0c483297d7ebb275c0e3129d63804ba0676af04c..874e6736a53fe27c438d26018c361da10b34ad9b 100644

--- a/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h

+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h

@@ -34,7 +34,7 @@ class IOSChromeMetricsServicesManagerClient

class IOSChromeEnabledStateProvider;

// metrics_services_manager::MetricsServicesManagerClient:

- std::unique_ptr<rappor::RapporService> CreateRapporService() override;

+ std::unique_ptr<rappor::RapporServiceImpl> CreateRapporServiceImpl() override;

std::unique_ptr<variations::VariationsService> CreateVariationsService()

override;

std::unique_ptr<metrics::MetricsServiceClient> CreateMetricsServiceClient()