Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/test/base/view_event_test_base.cc

Issue 25108005: linux_aura: Compile ash into chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win64 compile. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/view_event_test_base.cc
diff --git a/chrome/test/base/view_event_test_base.cc b/chrome/test/base/view_event_test_base.cc
index d8604c94b4b55f2b9b8743345bd12d2088c152ab..501291530309aca14a74e29ac0978b1ba2549839 100644
--- a/chrome/test/base/view_event_test_base.cc
+++ b/chrome/test/base/view_event_test_base.cc
@@ -117,13 +117,13 @@ void ViewEventTestBase::SetUp() {
#endif
#if defined(USE_ASH)
-#if defined(OS_WIN)
+#if !defined(OS_CHROMEOS)
// http://crbug.com/154081 use ash::Shell code path below on win_ash bots when
// interactive_ui_tests is brought up on that platform.
gfx::Screen::SetScreenInstance(
gfx::SCREEN_TYPE_NATIVE, views::CreateDesktopScreen());
-#else // !OS_WIN
+#else // !OS_CHROMEOS
// Ash Shell can't just live on its own without a browser process, we need to
// also create the message center.
message_center::MessageCenter::Initialize();
@@ -139,7 +139,7 @@ void ViewEventTestBase::SetUp() {
->SetActiveUserSessionStarted(true);
context = ash::Shell::GetPrimaryRootWindow();
context->GetHost()->Show();
-#endif // !OS_WIN
+#endif // !OS_CHROMEOS
aura::Env::CreateInstance();
#elif defined(USE_AURA)
// Instead of using the ash shell, use an AuraTestHelper to create and manage
@@ -163,17 +163,15 @@ void ViewEventTestBase::TearDown() {
ui::Clipboard::DestroyClipboardForCurrentThread();
#if defined(USE_ASH)
-#if !defined(OS_WIN)
- ash::Shell::DeleteInstance();
#if defined(OS_CHROMEOS)
+ ash::Shell::DeleteInstance();
chromeos::NetworkHandler::Shutdown();
chromeos::CrasAudioHandler::Shutdown();
chromeos::DBusThreadManager::Shutdown();
-#endif
// Ash Shell can't just live on its own without a browser process, we need to
// also shut down the message center.
message_center::MessageCenter::Shutdown();
-#endif // !OS_WIN
+#endif
aura::Env::DeleteInstance();
#elif defined(USE_AURA)
aura_test_helper_->TearDown();

Powered by Google App Engine
This is Rietveld 408576698