Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7891)

Unified Diff: chrome/chrome_tests.gypi

Issue 25108005: linux_aura: Compile ash into chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win64 compile. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 14e3b1afdb25b987406a2b1f0f39257a5e7b9f0d..bbf2d5613353e089075304d2219abb797cf0cba3 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1767,10 +1767,20 @@
],
}],
],
+ }, { # else: OS != "win"
+ 'sources!': [
+ 'app/chrome_command_ids.h',
+ 'app/chrome_dll.rc',
+ 'app/chrome_dll_resource.h',
+ 'app/chrome_version.rc.version',
+ ],
+ }],
+ ['chromeos==0 and use_aura==1', {
'sources!': [
- # use_aura currently sets use_ash on Windows. So take these tests out
- # for win aura builds.
- # TODO: enable these for win_ash browser tests.
+ # On Windows and Linux, we currently don't support enough of the
+ # ash environment to run these unit tests.
+ #
+ # TODO: enable these on windows and linux.
'browser/chromeos/system/tray_accessibility_browsertest.cc',
'browser/ui/ash/accelerator_commands_browsertest.cc',
'browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc',
@@ -1779,13 +1789,6 @@
'browser/ui/views/frame/app_non_client_frame_view_ash_browsertest.cc',
'browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc',
],
- }, { # else: OS != "win"
- 'sources!': [
- 'app/chrome_command_ids.h',
- 'app/chrome_dll.rc',
- 'app/chrome_dll_resource.h',
- 'app/chrome_version.rc.version',
- ],
}],
['OS=="linux"', {
'dependencies': [

Powered by Google App Engine
This is Rietveld 408576698