linux_aura: Compile ash into chrome.

chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc

Index: chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc
diff --git a/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc b/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc
index a63ebce3c490bbd109481c24ef43a0011bf3fc15..4eeee367f2c74a32a67d52ce3bda309a4cd2a09e 100644
--- a/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc
+++ b/chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc
@@ -49,13 +49,7 @@ ChromeBrowserMainExtraPartsAura::~ChromeBrowserMainExtraPartsAura() {
 }
 
 void ChromeBrowserMainExtraPartsAura::ToolkitInitialized() {
-#if !defined(OS_CHROMEOS)
-#if defined(USE_ASH)
-  active_desktop_monitor_.reset(new ActiveDesktopMonitor(GetInitialDesktop()));
-#endif
-#endif
-
-#if !defined(USE_ASH) && defined(OS_LINUX) && defined(USE_X11)
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // TODO(erg): Refactor this into a dlopen call when we add a GTK3 port.
   views::LinuxUI::SetInstance(BuildGtk2UI());
 #endif
@@ -64,6 +58,7 @@ void ChromeBrowserMainExtraPartsAura::ToolkitInitialized() {
 void ChromeBrowserMainExtraPartsAura::PostMainMessageLoopStart() {
 #if !defined(OS_CHROMEOS)
 #if defined(USE_ASH)
+  active_desktop_monitor_.reset(new ActiveDesktopMonitor(GetInitialDesktop()));

[sky, 2013/09/30 14:45:53]

How come you're moving initialization of this from ToolkitInitialized to
PostMainMessageLoopStart?

[Elliot Glaysher, 2013/09/30 20:53:40]

Because using ActiveDesktopMonitor required aura::Env which requires a
MessageLoop, at least on linux. Truncated stack of when the initialization is up
there:

[14600:14600:0930/133646:FATAL:message_loop.h(584)] Check failed: loop. 
 [0x7f1bd21f1dbe] base::debug::StackTrace::StackTrace()
 [0x7f1bd224e8ff] logging::LogMessage::~LogMessage()
 [0x7f1bd21c3602] base::MessageLoopForUI::current()
 [0x7f1bd21c260d] base::MessagePumpX11::Current()
 [0x7f1bcadd89e9] aura::Env::Init()
 [0x7f1bcadd89b5] aura::Env::GetInstance()
 [0x000001e6a999] ActiveDesktopMonitor::ActiveDesktopMonitor()
 [0x000001b5c6a1] ChromeBrowserMainExtraPartsAura::ToolkitInitialized()
 [0x000000e8fb6d] ChromeBrowserMainParts::ToolkitInitialized()
 [0x7f1bc8627cd6] content::BrowserMainLoop::InitializeToolkit()
 [0x7f1bc8630446] content::BrowserMainRunnerImpl::Initialize()

   if (!chrome::ShouldOpenAshOnStartup())
 #endif
   {