linux_aura: Compile ash into chrome.

chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h"
 
 #include "chrome/browser/chrome_browser_main.h"
 #include "chrome/browser/ui/aura/active_desktop_monitor.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "ui/aura/env.h"
@@ skipping 31 matching lines @@
 
 }  // namespace
 
 ChromeBrowserMainExtraPartsAura::ChromeBrowserMainExtraPartsAura() {
 }
 
 ChromeBrowserMainExtraPartsAura::~ChromeBrowserMainExtraPartsAura() {
 }
 
 void ChromeBrowserMainExtraPartsAura::ToolkitInitialized() {
-#if !defined(OS_CHROMEOS)
-#if defined(USE_ASH)
-  active_desktop_monitor_.reset(new ActiveDesktopMonitor(GetInitialDesktop()));
-#endif
-#endif
-
-#if !defined(USE_ASH) && defined(OS_LINUX) && defined(USE_X11)
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // TODO(erg): Refactor this into a dlopen call when we add a GTK3 port.
   views::LinuxUI::SetInstance(BuildGtk2UI());
 #endif
 }
 
 void ChromeBrowserMainExtraPartsAura::PostMainMessageLoopStart() {
 #if !defined(OS_CHROMEOS)
 #if defined(USE_ASH)
+  active_desktop_monitor_.reset(new ActiveDesktopMonitor(GetInitialDesktop()));

[sky, 2013/09/30 14:45:53]

How come you're moving initialization of this from ToolkitInitialized to
PostMainMessageLoopStart?

[Elliot Glaysher, 2013/09/30 20:53:40]

Because using ActiveDesktopMonitor required aura::Env which requires a
MessageLoop, at least on linux. Truncated stack of when the initialization is up
there:

[14600:14600:0930/133646:FATAL:message_loop.h(584)] Check failed: loop. 
 [0x7f1bd21f1dbe] base::debug::StackTrace::StackTrace()
 [0x7f1bd224e8ff] logging::LogMessage::~LogMessage()
 [0x7f1bd21c3602] base::MessageLoopForUI::current()
 [0x7f1bd21c260d] base::MessagePumpX11::Current()
 [0x7f1bcadd89e9] aura::Env::Init()
 [0x7f1bcadd89b5] aura::Env::GetInstance()
 [0x000001e6a999] ActiveDesktopMonitor::ActiveDesktopMonitor()
 [0x000001b5c6a1] ChromeBrowserMainExtraPartsAura::ToolkitInitialized()
 [0x000000e8fb6d] ChromeBrowserMainParts::ToolkitInitialized()
 [0x7f1bc8627cd6] content::BrowserMainLoop::InitializeToolkit()
 [0x7f1bc8630446] content::BrowserMainRunnerImpl::Initialize()

   if (!chrome::ShouldOpenAshOnStartup())
 #endif
   {
     gfx::Screen::SetScreenInstance(gfx::SCREEN_TYPE_NATIVE,
                                    views::CreateDesktopScreen());
   }
 #endif
 }
 
 void ChromeBrowserMainExtraPartsAura::PostMainMessageLoopRun() {
   active_desktop_monitor_.reset();
 
   // aura::Env instance is deleted in BrowserProcessImpl::StartTearDown
   // after the metrics service is deleted.
 }