Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2510763002: Fired PointerEvent from Node::dispatchMouseEvent() to fix a bug. (Closed)

Created:
4 years, 1 month ago by mustaq
Modified:
4 years, 1 month ago
Reviewers:
bokan, dtapuska
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fired PointerEvent from Node::dispatchMouseEvent() to fix a bug. This is an urgent fix to make pointerups visible in M55 for sites with flash objects. The ideal solution would be to remove all direct event dispatches for plugins and PointerLocks, instead route all PlaformMouseEvents through EventHandler. BUG=659670 Committed: https://crrev.com/b649bb81f5ea6d908cfb3db1506219678e654d33 Cr-Commit-Position: refs/heads/master@{#432889}

Patch Set 1 #

Patch Set 2 : Added a layout test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-on-object.html View 1 1 chunk +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +70 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
mustaq
ptal
4 years, 1 month ago (2016-11-16 17:15:33 UTC) #2
dtapuska
On 2016/11/16 17:15:33, mustaq wrote: > ptal sgtm can we add a test perhaps with ...
4 years, 1 month ago (2016-11-16 17:22:30 UTC) #3
mustaq
On 2016/11/16 17:22:30, dtapuska wrote: > On 2016/11/16 17:15:33, mustaq wrote: > > ptal > ...
4 years, 1 month ago (2016-11-16 20:20:33 UTC) #4
mustaq
bokan@chromium.org: Please review changes in Source/core.
4 years, 1 month ago (2016-11-16 20:21:32 UTC) #6
dtapuska
On 2016/11/16 20:21:32, mustaq wrote: > mailto:bokan@chromium.org: Please review changes in Source/core. Lgtm
4 years, 1 month ago (2016-11-16 20:44:29 UTC) #7
bokan
lgtm
4 years, 1 month ago (2016-11-17 14:25:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510763002/20001
4 years, 1 month ago (2016-11-17 14:30:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 16:21:57 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 16:23:40 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b649bb81f5ea6d908cfb3db1506219678e654d33
Cr-Commit-Position: refs/heads/master@{#432889}

Powered by Google App Engine
This is Rietveld 408576698