Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2510763002: Fired PointerEvent from Node::dispatchMouseEvent() to fix a bug. (Closed)
Patch Set: Added a layout test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.h
diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h
index 55bb344c0133a4fd17104f43a0b39a579ff551d9..4fe91f7973b65aebc0ec3a36191fd0a949ac512a 100644
--- a/third_party/WebKit/Source/core/dom/Node.h
+++ b/third_party/WebKit/Source/core/dom/Node.h
@@ -720,10 +720,10 @@ class CORE_EXPORT Node : public EventTarget {
DispatchEventResult dispatchDOMActivateEvent(int detail,
Event& underlyingEvent);
- DispatchEventResult dispatchMouseEvent(const PlatformMouseEvent&,
- const AtomicString& eventType,
- int clickCount = 0,
- Node* relatedTarget = nullptr);
+ void dispatchMouseEvent(const PlatformMouseEvent&,
+ const AtomicString& eventType,
+ int clickCount = 0,
+ Node* relatedTarget = nullptr);
void dispatchSimulatedClick(
Event* underlyingEvent,
@@ -844,6 +844,13 @@ class CORE_EXPORT Node : public EventTarget {
void setFlag(NodeFlags mask) { m_nodeFlags |= mask; }
void clearFlag(NodeFlags mask) { m_nodeFlags &= ~mask; }
+ // TODO(mustaq): This is a hack to fix sites with flash objects. We should
+ // instead route all PlatformMouseEvents through EventHandler. See
+ // crbug.com/665924.
+ void createAndDispatchPointerEvent(const AtomicString& mouseEventName,
+ const PlatformMouseEvent&,
+ LocalDOMWindow* view);
+
protected:
enum ConstructionType {
CreateOther = DefaultNodeFlags,

Powered by Google App Engine
This is Rietveld 408576698